[#230] Add hoistMaybe and hoistEither functions
#231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpevnev
commented
Aug 19, 2020
Martoon-00
approved these changes
Aug 19, 2020
gromakovsky
reviewed
Aug 24, 2020
|
@gromakovsky should I add it as a new minor version ( |
|
If I understand PVP correctly, yes. Typically we write |
Problem: Currently to lift a value `ma :: Maybe a` into `MaybeT m a`` you need to write `MaybeT (pure ma)`, which is bloating code with unnecessary boilerplate. Same idea applies for `Either e a` and `ExceptT e m a`. ` Proposed solution: Add functions `hoistMaybe :: Applicative m => Maybe a -> MaybeT m a` and `hoistEither :: Applicative m => Either e a -> ExceptT e m a `
gpevnev
force-pushed
the
gpevnev/#230-add-hoist-maybe
branch
from
5162044
to
bdbf082
Compare
gromakovsky
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Currently to lift a value
ma :: Maybe aintoMaybeT m ayou need to write
MaybeT (pure ma), which is bloating code withunnecessary boilerplate.
Same idea applies for
Either e aandExceptT e m a.`
Proposed solution:
Add functions
hoistMaybe :: Applicative m => Maybe a -> MaybeT m aandhoistEither :: Applicative m => Either e a -> ExceptT e m aRelated issues
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
reference this issue. See also auto linking on
github.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
and
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.