Support GHC-9.2.2 #252
Merged
Support GHC-9.2.2 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
gromakovsky
force-pushed
the
gromak/support-ghc-9.2
branch
from
e1833bd
to
47b3bbc
Compare
gromakovsky
force-pushed
the
gromak/support-ghc-9.2
branch
from
ec77331
to
e3d2335
Compare
Problem: `Option` type is useless nowadays because it's absolutely equivalent to `Maybe`. It exists for historical reasons, it was deprecated in base-4.15 and removed in base-4.16. So Universum.Monoid no longer compiles with base-4.16. Solution: just remove this re-export because properly deprecating it supporting multiple GHC versions will likely involve too much CPP and doesn't sound paricularly useful because hopefully nobody used Option anyway (it's pretty much useless for a long time).
Support 9.2.2, drop support for 8.4.4 to avoid supporting too many versions (which is tedious).
Otherwise the compiler doesn't like the following constraint: `SuperComposition (a -> b) d r1`.
This is a new warning in GHC, it wants us to write ``` type ToPairs :: * -> Constraint ``` in addition to ``` class ToPairs t where ``` I am not sure it's a good idea to require it everywhere, so for now I just disable this warning to let the existing code compile without warnings.
Problem: universum-doctest passes with GHC < 9, but starts to fail with >= 9. The errors are weird, it complains that a lot of stuff is not in scope. Example: > Not in scope: type constructor or class ‘Text’ Solution: there is the following issue sol/doctest#327. Apparently, something is wrong in `doctest` itself. The maintainer intends to investigate it, so let's wait for that. While waiting, let's disable `universum-doctest` whenever GHC is >= 9.0.0.
gromakovsky
force-pushed
the
gromak/support-ghc-9.2
branch
from
f141e20
to
0b230f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary goal of this PR is to make sure that
universumcan be built with GHC-9.2.2.Related issues(s)
None
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
reference this issue. See also auto linking on
github.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
and
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.