Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#77] Add modify' function #78

Merged
merged 2 commits into from
Nov 4, 2017
Merged

[#77] Add modify' function #78

merged 2 commits into from
Nov 4, 2017

Conversation

vrom911
Copy link
Contributor

@vrom911 vrom911 commented Nov 4, 2017

No description provided.

@vrom911 vrom911 self-assigned this Nov 4, 2017
@vrom911 vrom911 requested a review from chshersh November 4, 2017 21:29
CHANGES.md Outdated
@@ -1,3 +1,9 @@
0.7.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove .0 from version here and from .cabal file? Workflow to our project suggests to use only 3 numbers in version. But sometimes I pretend that I'm not aware of this rule and in case of documentation changes it's ok to add 4th number. But in general we should follow our style-guide...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sure!

@chshersh chshersh merged commit a2ebb28 into master Nov 4, 2017
@chshersh chshersh deleted the vrom911/77-modify branch November 4, 2017 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants