This repository has been archived by the owner on May 1, 2020. It is now read-only.
Add support for custom method invocation on a template file. #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve the problem discussed in issue #497.
This is my take on the problem, @eahefnawy please see the explanation below and let me know if you have a different idea about the implementation:
Solution
Everything is handled by the
Template
component, so fromcli
perspective nothing is changed.The cool part is, when
cli
checks if the component has a custom method, and the component happens to be an instance ofTemplate
, theProxy
will return a "proxy" function to execute custom methods . Parameters--component
are located in theinputs
, so we can easily treat them equally from both CLI and programmatic perspective.Below is the example invocation and the resulting output:
Let me know what you think and if any changes are required 🍻