-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate insert_many (and add splice?) #255
Comments
@mbrubeck I would like to put in a request for a I've implemented a crate that exposes several types that would be appropriate to implement Ruby's The
|
The
insert_many
function is complicated, and has had several bugs and vulnerabilities (#96, #208, #252). Unlike mostSmallVec
methods, it does not correspond to a standardVec
method. Perhaps because of this, it is rarely used. Should we deprecate this method, and remove it in the next major version?The standard
Vec::splice
method could be used in place ofinsert_many
, butSmallVec
does not yet implement this method. We could add this, possibly by copying the implementation fromstd::vec
, if there is demand for it.The text was updated successfully, but these errors were encountered: