Impl get_size::GetSize (behind feature flag) (v2 branch) #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrubeck
requested changes
Jan 17, 2024
Shows memory usage of the struct cf. issue servo#331
amandasaurus
force-pushed
the
get-size-v2
branch
from
5d09b91
to
6ba09d0
Compare
|
I've fixed those 2 things, and pushed a new branch. |
mbrubeck
approved these changes
Jan 18, 2024
mbrubeck
added a commit
that referenced
this pull request
Jan 19, 2024
This reverts commit cf03b15. Avoids a cyclic dependency when the build includes the `get-size/derive` feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows memory usage of the struct
cf. issue #331
this is against the
v2branch. The tests pass, but I haven't tried this code in real uses yet.