Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .taskcluster.yml file to run CI using taskcluster #1746

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

staktrace
Copy link
Contributor

@staktrace staktrace commented Sep 22, 2017

This is a test PR to see if (a) taskcluster correctly picks up the PR and schedules the CI jobs and (b) to see how bors/homu deal with this extra CI job.

This is related to #1724


This change is Reviewable

On the taskcluster Linux machines a reftest gives slightly different
results so the reftest.list is tweaked as well.
@staktrace
Copy link
Contributor Author

Ok, that was anticlimactic. I'm not sure what's the best way forward here. Somebody who knows more about how the CI checks work with the bors/homu bots should chime in. Otherwise I'd say we should merge this PR but be ready to back it out if it causes problems. In theory the taskcluster jobs should always be green for good PRs so it should be safe to run them side-by-side with the travis CI until we're confident it doesn't break stuff.

@glennw
Copy link
Member

glennw commented Sep 24, 2017

@staktrace I'm fine with merging this - we can back it out if required. But why the change to fuzzy results in one of the reftests?

@staktrace
Copy link
Contributor Author

@glennw On the taskcluster Linux machines that reftest gives slightly different
results so I had to tweak the reftest.list to make the test pass.

@staktrace
Copy link
Contributor Author

I continued looking into what we need to complete the integration and posted to #1724 (comment). Even without the integration complete, I think it would be valuable to merge this PR, because we'll get taskcluster running CI and can get results faster than via Travis. Even if bors/homu don't yet recognize those results, the human doing the PR can get feedback faster which would be valuable.

@glennw
Copy link
Member

glennw commented Sep 25, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0bec79b has been approved by glennw

bors-servo pushed a commit that referenced this pull request Sep 25, 2017
Add a .taskcluster.yml file to run CI using taskcluster

This is a test PR to see if (a) taskcluster correctly picks up the PR and schedules the CI jobs and (b) to see how bors/homu deal with this extra CI job.

This is related to #1724

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1746)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 0bec79b with merge 3664fa4...

@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: glennw
Pushing 3664fa4 to master...

@bors-servo bors-servo merged commit 0bec79b into servo:master Sep 25, 2017
@staktrace staktrace deleted the taskcluster-ci branch September 25, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants