Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Schemazen library project #99

Merged
merged 26 commits into from
Jun 27, 2016
Merged

Created Schemazen library project #99

merged 26 commits into from
Jun 27, 2016

Conversation

marcio-santos-zocdoc
Copy link
Contributor

@sethreno

@colin-hanson-zocdoc, @Tony-Zheng-Zocdoc, @scott-roepnack-zocdoc and me are using heavily your project here at zocdoc. These changes are to create a library that contains all schemazen functionality. The schemazen console app behaviour is the same, we added some tests as well.

Changes:

  • 2 projects: Schemazen.Console and Schemazen.Library
  • Schemazen.Library contains:
    • Model classes
    • Logger
    • SqlParser
    • And the new classes CompareCommand, CreateCommand and ScriptCommand. We moved logic from Create, Compare and Script classes into this new classes.
  • Schemazen.Console contains all console logic and uses the Schemazen.Library

Let me know if you want to talk more about these changes.

colin-hanson-zocdoc and others added 26 commits April 21, 2016 15:18
Added parameter filterTypes to schemazen script command
# Conflicts:
#	model/Models/Database.cs
@sethreno
Copy link
Owner

Thanks for taking the time to submit a pull request for this. There's a lot here so If I have any questions or comments I'll start the conversation on the individual commit. Cheers.

@sethreno sethreno merged commit d378538 into sethreno:master Jun 27, 2016
@sethreno
Copy link
Owner

I looked over these and merged them. I have a couple requests for future commits that would help make it easier for me to review:

  • Please reference issue numbers in the commit message. Without this I need to review each commit and cross reference the issue list. Not a huge deal, but a little time consuming.
  • Please use existing formatting. Tabs not spaces, no newline before {, etc.. Changing the formatting makes it look like the entire file changed. See 39d719a for an example. This is a common issue with pull requests I receive. From time to time I will reformat the entire solution to make it consistent. I'd prefer not to do this though as it makes the history harder to follow.

I hope I don't seem nit-picky. I do appreciate the pull request. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants