Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis of a common UI for all plugins #261

Closed
wants to merge 95 commits into from

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented May 26, 2020

This is a basis for creating portable UI.
It's based on Pugl and Elements libraries, it drops VSTGUI entirely, and it's implemented in LV2 and VST.

No proper UI at the moment, only the SliderAndKnobs demo.

EDIT a note to self

  • make building the LV2 UI optional, for 2 reasons
    • MOD devices require ui-less plugins
    • the Elements lib requires C++14, the MOD toolchain is still at C++11

@jpcima jpcima force-pushed the editor+elements branch 2 times, most recently from d214921 to 5451ce9 Compare May 28, 2020 17:02
@paulfd
Copy link
Member

paulfd commented May 28, 2020

This looks nice! I can debug the windows build if it's a mess for you. I have a windows install.

@jpcima
Copy link
Collaborator Author

jpcima commented May 28, 2020

I leave you a link to the current problem. I guess a cairo custom port could fix this.
microsoft/vcpkg#11640

On the status of this thing, I allowed it to work in Windows and Mac in all VST/LV2/AU.
The elements library, it's back ported to C++14 so it can build this in most of configurations.

Pugl has some crashes which I resolved but they're not in upstream.
For reference,

@redtide works on designing a real UI on the basis of this PR, he makes it in a separate branch.

Next this will need some sort of adapter in between plugin and UI, to fit the behavior with each of plugin formats. This layer should be allowed to communicate in both directions.


Sfizz LV2 plugin

Copyright 2019-2020, Paul Ferrand <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hem :D

@jpcima jpcima force-pushed the editor+elements branch 4 times, most recently from 0b5c121 to 870ccf3 Compare June 9, 2020 20:28
@jpcima
Copy link
Collaborator Author

jpcima commented Jun 12, 2020

@paulfd when you're able, you can check if de51bfa fixes the X11 error.
It reproduces uncertainly because of being an apparent race condition involving the display server, but it's easier by slowing down the program. (valgrind comes in handy for this purpose)

@jpcima jpcima force-pushed the editor+elements branch 2 times, most recently from d17d05e to 6a22e67 Compare June 18, 2020 17:02
@jpcima
Copy link
Collaborator Author

jpcima commented Jun 18, 2020

A basic UI is done, connected to plugin controls.
The tuning fonctionality is in LV2, but remains to be implemented in VST plugin side.

@jpcima jpcima closed this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants