Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(native_image): add static_zlib #73

Closed
wants to merge 4 commits into from
Closed

feat(native_image): add static_zlib #73

wants to merge 4 commits into from

Commits on Aug 31, 2023

  1. fix(native_image): Clean up args building 

    Make use of `Args` lazy string formatting to save memory.
Also pass in compiler options as repeated flags, not joined on spaces,
to prevent issues when compiler options contain spaces.
    @fmeum
    fmeum committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    a131805 View commit details
    Browse the repository at this point in the history

  2. fix(native_image): clean up construction of inputs 

    `depset` structures should be kept as flat as possible. C++ toolchain
files are also already `depset`s and thus shouldn't be passed into
`tools`.
    @fmeum
    fmeum committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    94796f0 View commit details
    Browse the repository at this point in the history

  3. fix(native_image): fix C++ toolchain env setup 

    Instead of relying on the default shell env, get the environment
variables declared by the C++ toolchain. On macOS, additionally use
`apple_support` to pass in `DEVELOPER_DIR`.

Since GraalVM sanitizes the environment, all variables are translated
into `-E` flags.
    @fmeum
    fmeum committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    a658128 View commit details
    Browse the repository at this point in the history

  4. feat(native_image): add static_zlib 

    When provided, the static zlib library will be used when Graal
statically links in zlib.
    @fmeum
    fmeum committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    91087ba View commit details
    Browse the repository at this point in the history