Fix Service[oddjobd] failing to start

Without this patch the initial Puppet run fails with the following error
message:

    Error: Could not start Service[oddjobd]: Execution of '/sbin/service oddjobd
    start' returned 1: Starting oddjobd: [FAILED]

The cause of this error is that the `messagebus` service is not started.  This
patch addresses the problem by adding optional management of dependent services
to the sssd::services class.  Since these dependencies aren't strictly related
to sssd they can easily be overridden by setting sssd::service_dependencies to
an empty array in Hiera.

manifests/init.pp

@@ -29,6 +29,11 @@
 # [*service_ensure*]
 # Ensure if services should be running/stopped
 #
+# [*service_dependencies*]
+# Array of service resource names to manage before managing sssd related
+# services. Intended to be used to manage messagebus service to prevent
+# `Error: Could not start Service[oddjobd]`.
+#
 # === Examples
 #
 # class {'::sssd':
@@ -76,6 +81,7 @@
  $mkhomedir = $sssd::params::mkhomedir,
  $manage_oddjobd = $sssd::params::manage_oddjobd,
  $service_ensure = $sssd::params::service_ensure,
+ $service_dependencies = $sssd::params::service_dependencies,
  $enable_mkhomedir_flags = $sssd::params::enable_mkhomedir_flags,
  $disable_mkhomedir_flags = $sssd::params::disable_mkhomedir_flags,
 ) inherits sssd::params {
@@ -93,7 +99,8 @@
  validate_array(
  $extra_packages,
  $enable_mkhomedir_flags,
- $disable_mkhomedir_flags
+ $disable_mkhomedir_flags,
+ $service_dependencies
  )
 
  validate_absolute_path(

manifests/params.pp

@@ -32,6 +32,7 @@
  $sssd_package = 'sssd'
  $sssd_service = 'sssd'
  $service_ensure = 'running'
+ $service_dependencies = ['messagebus']
  $config_file = '/etc/sssd/sssd.conf'
  $mkhomedir = true
 
@@ -57,6 +58,7 @@
  $sssd_package = 'sssd'
  $sssd_service = 'sssd'
  $service_ensure = 'running'
+ $service_dependencies = []
  $config_file = '/etc/sssd/sssd.conf'
  $mkhomedir = true
  $extra_packages = [

manifests/service.pp

@@ -1,10 +1,22 @@
 # See README.md for usage information
 class sssd::service (
- $sssd_service = $sssd::sssd_service,
- $mkhomedir = $sssd::mkhomedir,
- $manage_oddjobd = $sssd::manage_oddjobd,
- $service_ensure = $sssd::service_ensure,
+ $sssd_service = $sssd::sssd_service,
+ $mkhomedir = $sssd::mkhomedir,
+ $manage_oddjobd = $sssd::manage_oddjobd,
+ $service_dependencies = $sssd::service_dependencies,
+ $service_ensure = $sssd::service_ensure,
 ) {
+
+ if ! empty($service_dependencies) {
+ service { $service_dependencies:
+ ensure => running,
+ hasstatus => true,
+ hasrestart => true,
+ enable => true,
+ before => Service["$sssd_service"]
+ }
+ }
+
  service { $sssd_service:
  ensure => $service_ensure,
  enable => true,