Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: internal to hidden #77

Merged
merged 3 commits into from
Jul 13, 2023
Merged

fix: internal to hidden #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a36a7b4
fix: replace internal with hidden for types
sgratzl Jul 13, 2023
907ffe0
build: redo yarn.lock
sgratzl Jul 13, 2023
d18e7a1
Merge remote-tracking branch 'origin/dev' into sgratzl/hidden
sgratzl Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/controllers/DendrogramController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ export interface ITreeOptions {

export class DendrogramController extends GraphController {
/**
* @internal
* @hidden
*/
declare options: { tree: ITreeOptions };

/**
* @internal
* @hidden
*/
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
updateEdgeElement(line: EdgeLine, index: number, properties: any, mode: UpdateMode): void {
Expand All @@ -50,7 +50,7 @@ export class DendrogramController extends GraphController {
}

/**
* @internal
* @hidden
*/
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
updateElement(point: Element<AnyObject, AnyObject>, index: number, properties: any, mode: UpdateMode): void {
Expand Down Expand Up @@ -131,7 +131,7 @@ export class DendrogramController extends GraphController {
static readonly id: string = 'dendrogram';

/**
* @internal
* @hidden
*/
static readonly defaults: any = /* #__PURE__ */ merge({}, [
GraphController.defaults,
Expand All @@ -151,7 +151,7 @@ export class DendrogramController extends GraphController {
]);

/**
* @internal
* @hidden
*/
static readonly overrides: any = /* #__PURE__ */ merge({}, [
GraphController.overrides,
Expand Down Expand Up @@ -211,7 +211,7 @@ export class DendogramController extends DendrogramController {
static readonly id: string = 'dendogram';

/**
* @internal
* @hidden
*/
static readonly defaults: any = /* #__PURE__ */ merge({}, [
DendrogramController.defaults,
Expand Down
10 changes: 5 additions & 5 deletions src/controllers/ForceDirectedGraphController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,12 @@ export interface IRadialForce {

export class ForceDirectedGraphController extends GraphController {
/**
* @internal
* @hidden
*/
declare options: IForceDirectedControllerOptions;

/**
* @internal
* @hidden
*/
private readonly _simulation: Simulation<SimulationNodeDatum, undefined>;

Expand Down Expand Up @@ -204,7 +204,7 @@ export class ForceDirectedGraphController extends GraphController {
}

/**
* @internal
* @hidden
*/
_copyPosition(): void {
const nodes = this._cachedMeta._parsed as ITreeSimNode[];
Expand Down Expand Up @@ -344,7 +344,7 @@ export class ForceDirectedGraphController extends GraphController {
static readonly id = 'forceDirectedGraph';

/**
* @internal
* @hidden
*/
static readonly defaults: any = /* #__PURE__ */ merge({}, [
GraphController.defaults,
Expand All @@ -367,7 +367,7 @@ export class ForceDirectedGraphController extends GraphController {
]);

/**
* @internal
* @hidden
*/
static readonly overrides: any = /* #__PURE__ */ merge({}, [
GraphController.overrides,
Expand Down
64 changes: 32 additions & 32 deletions src/controllers/GraphController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,57 +45,57 @@ export interface ITreeEdge {

export class GraphController extends ScatterController {
/**
* @internal
* @hidden
*/
declare _ctx: CanvasRenderingContext2D;

/**
* @internal
* @hidden
*/
declare _cachedDataOpts: any;

/**
* @internal
* @hidden
*/
declare _type: string;

/**
* @internal
* @hidden
*/
declare _data: any[];

/**
* @internal
* @hidden
*/
declare _edges: any[];

/**
* @internal
* @hidden
*/
declare _sharedOptions: any;

/**
* @internal
* @hidden
*/
declare _edgeSharedOptions: any;

/**
* @internal
* @hidden
*/
declare dataElementType: any;

/**
* @internal
* @hidden
*/
private _scheduleResyncLayoutId = -1;

/**
* @internal
* @hidden
*/
edgeElementType: any;

/**
* @internal
* @hidden
*/
private readonly _edgeListener = {
_onDataPush: (...args: any[]) => {
Expand Down Expand Up @@ -136,7 +136,7 @@ export class GraphController extends ScatterController {
};

/**
* @internal
* @hidden
*/
initialize(): void {
const type = this._type;
Expand All @@ -148,7 +148,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
parse(start: number, count: number): void {
const meta = this._cachedMeta;
Expand Down Expand Up @@ -177,15 +177,15 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
reset(): void {
this.resetLayout();
super.reset();
}

/**
* @internal
* @hidden
*/
update(mode: UpdateMode): void {
super.update(mode);
Expand All @@ -197,7 +197,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
destroy(): void {
(ScatterController.prototype as any).destroy.call(this);
Expand All @@ -208,7 +208,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
updateEdgeElements(edges: EdgeLine[], start: number, mode: UpdateMode): void {
const bak = {
Expand Down Expand Up @@ -274,15 +274,15 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
updateEdgeElement(edge: EdgeLine, index: number, properties: any, mode: UpdateMode): void {
super.updateElement(edge as unknown as Element<AnyObject, AnyObject>, index, properties, mode);
}

/**
* @internal
* @hidden
*/
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
updateElement(point: Element<AnyObject, AnyObject>, index: number, properties: any, mode: UpdateMode): void {
Expand All @@ -296,7 +296,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
resolveNodeIndex(nodes: any[], ref: string | number | any): number {
if (typeof ref === 'number') {
Expand Down Expand Up @@ -326,7 +326,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
buildOrUpdateElements(): void {
const dataset = this.getDataset() as any;
Expand All @@ -350,7 +350,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
draw(): void {
const meta = this._cachedMeta;
Expand Down Expand Up @@ -422,7 +422,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
_parseDefinedEdge(edge: { source: number; target: number }): ITreeEdge {
const ds = this.getDataset();
Expand All @@ -435,7 +435,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
_parseEdges(): ITreeEdge[] {
const ds = this.getDataset() as any;
Expand Down Expand Up @@ -465,7 +465,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
addElements(): void {
super.addElements();
Expand All @@ -482,7 +482,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
_resyncEdgeElements(): void {
const meta = this._cachedMeta as unknown as IExtendedChartMeta;
Expand All @@ -499,7 +499,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
_insertElements(start: number, count: number): void {
(ScatterController.prototype as any)._insertElements.call(this, start, count);
Expand All @@ -509,7 +509,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
_removeElements(start: number, count: number): void {
(ScatterController.prototype as any)._removeElements.call(this, start, count);
Expand All @@ -519,7 +519,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
_insertEdgeElements(start: number, count: number): void {
const elements = [];
Expand Down Expand Up @@ -548,7 +548,7 @@ export class GraphController extends ScatterController {
}

/**
* @internal
* @hidden
*/
_scheduleResyncLayout(): void {
if (this._scheduleResyncLayoutId != null && this._scheduleResyncLayoutId >= 0) {
Expand All @@ -568,7 +568,7 @@ export class GraphController extends ScatterController {
static readonly id: string = 'graph';

/**
* @internal
* @hidden
*/
static readonly defaults: any = /* #__PURE__ */ merge({}, [
ScatterController.defaults,
Expand All @@ -585,7 +585,7 @@ export class GraphController extends ScatterController {
]);

/**
* @internal
* @hidden
*/
static readonly overrides: any = /* #__PURE__ */ merge({}, [
(ScatterController as any).overrides,
Expand Down
4 changes: 2 additions & 2 deletions src/controllers/TreeController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export class TreeController extends DendrogramController {
static readonly id = 'tree';

/**
* @internal
* @hidden
*/
static readonly defaults: any = /* #__PURE__ */ merge({}, [
DendrogramController.defaults,
Expand All @@ -29,7 +29,7 @@ export class TreeController extends DendrogramController {
]);

/**
* @internal
* @hidden
*/
static readonly overrides: any = /* #__PURE__ */ DendrogramController.overrides;
}
Expand Down
Loading