Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processing small web VTT results in END_OF_STREAM error if there is no empty line at end. #1217

Closed
duggaraju opened this issue Jun 8, 2023 · 0 comments · Fixed by #1216 or #1312
Closed

Processing small web VTT results in END_OF_STREAM error if there is no empty line at end. #1217

duggaraju opened this issue Jun 8, 2023 · 0 comments · Fixed by #1216 or #1312
Labels
status: archived Archived and locked; will not be updated

Comments

@duggaraju
Copy link
Contributor

System info

Operating System: All
Shaka Packager Version: v2.6.1-634af65-release

Issue and steps to reproduce the problem

Packager Command:

Extra steps to reproduce the problem?
D:\media\backup>c:\Users\krishndu\source\repos\AMSMigrate\AMSMigrate\packager-win-x64.exe in=sample.vtt.txt,stream=text,
out=out.vtt
[0608/134947:INFO:demuxer.cc(89)] Demuxer::Run() on file 'sample.vtt.txt'.
[0608/134947:INFO:demuxer.cc(155)] Initialize Demuxer for file 'sample.vtt.txt'.
[0608/134947:ERROR:packager_main.cc(554)] Packaging Error: 6 (END_OF_STREAM):

What is the expected result?
The packager succeeds.

What happens instead?
Packager fails with END_OF_STREAM error. If I add an empty line at the end of file it succeeds. Per webvtt spec the empty line at the end is optional. Also shaka doesn't fail always. if you have larger files which requires multiple reads then this error doesn't happen.

<Please attach the input files or email to [email protected].>

sample.vtt.txt
@joeyparrish joeyparrish mentioned this issue Jul 12, 2023
Merged
joeyparrish pushed a commit that referenced this issue Jul 12, 2023
@xieyubo
fix: Fix failure on very short WebVTT files (#1216)
dab165d 
Fix a bug that if the webvtt file is very short, e.g. only contains one
block

    WEBVTT

    00:00:00.500 --> 00:00:02.000
    The Web is always changing

shaka packager will report error: "Packaging Error: 6 (END_OF_STREAM)".

Fixes #1217
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Sep 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
1 participant
@duggaraju