-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build shaka-packager with GCC 13- missing stdint fixed bits integer types #1305
Labels
status: archived
Archived and locked; will not be updated
Comments
modernletter
added a commit
to modernletter/shaka-packager
that referenced
this issue
Nov 28, 2023
GCC version 13 needs <cstdint> to be explicitly included to provide fixed bits integer types. Some files using it inludes <stdint.h>, this commit adds <cstdint> inclusion to the missing ones and it's needed to compile project on GCC 13. Source: https://gcc.gnu.org/gcc-13/porting_to.html
cosmin
pushed a commit
that referenced
this issue
Nov 30, 2023
CC version 13 needs `<cstdint>` to be explicitly included to provide fixed bits integer types. Some files using it inludes `<stdint.h>`, some are missing direct or undirect inclusion. This PR adds `<cstdint>` inclusion to the minimal set of files, allowing compilation on GCC 13. Closes #1305
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Jan 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
System info
Operating System: Arch Linux ([email protected]),
Shaka Packager Version: current, 8465f5f
GCC Version: 13.2.1 20230801
Issue and steps to reproduce the problem
Packager Command:
Extra steps to reproduce the problem?
What is the expected result?
Project compiles.
What happens instead?
Project doesn't compile.
GCC version 13 needs
<cstdint>
(or<stdint.h>
) to be explicitly included to provide fixed bits integer types. It appears that some source files are actually using e.g. uint64_t without including it.I would like to propose a PR adding needed includes.
Source: https://gcc.gnu.org/gcc-13/porting_to.html
The text was updated successfully, but these errors were encountered: