-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript's number overflow for timescale 10000000 (PlayReady/SmoothStreaming default) #1667
Comments
Example fix based on https:/peterolson/BigInteger.js attached. |
I'm sorry, but we are not going to add a BigInteger library to support extremely large timescales. This additional dependency would not be optional and would increase the size of Shaka Player by ~20%. I know this is probably disappointing to hear, but we won't support content that creates Numbers too large to be exact integers in JavaScript (2^53). Please fix your timescale to something more reasonable. |
We will update our README and FAQ to document this. I apologize for the inconvenience. |
This may be interesting to all parties: https:/tc39/proposal-bigint |
Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
commit 1831ce9
Can you reproduce the issue with our latest release version?:
Yes
Can you reproduce the issue with the latest code from
master
?:Yes
Are you using the demo app or your own custom app?:
Demo app
What browser and OS are you using?:
Chrome, LG WebOS SmartTV, Samsung Tizen SmartTV
What did you do?
Trying to play content with timescale = 10,000,000 (10 millions) and chunk template with "$Time$" placeholder.
It's a "default timescale" for SmoothStreaming and it is required by several legacy TV models (Samsung Tizen 2015, for example).
The problem is caused by:
What did you expect to happen?
Play content normally
What actually happened?
Shaka generates invalid chunk name -> 404 from the server.
The text was updated successfully, but these errors were encountered: