feat: add Sass implementation #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an official sass port of Tuesday.
Funnily enough this was the very first issue posted as soon as Tuesday went public (#1), we didn't give much attention because we weren't using Sass that much internally at Shakr. Well it's 2020 now and yes we still do use Less for our main code but we started using Sass for other side projects so I decided why not try converting keyframes to Sass.
Based on node-sass compatible syntax (Hence it uses
@importinstead of the newer@use) due to low adoption rate of dart-sass as of June 2020 (https://www.npmtrends.com/dart-sass-vs-node-sass)Sass version will only support keyframes imports through
@includeand is not used for main CSS build for distribution.After merge, I'm planning to deprecate npm package "tuesday.less" in favor of "tuesday.css" (because now the repo contains source files both in less and sass) https://www.npmjs.com/package/tuesday.less