Adds two new doc events: 'before op batch' and 'after op batch' #247
+55
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently upgraded from ShareJS to ShareDB following the migration guide. We've replaced
after op
with theop
event, but we have found thatop
is called for each individual operation, as opposed toafter op
which had been called after an entire batch of operations.The addition of two new events that get called at the start, and the end, of a batch of operations allows us perform the optimizations we were doing previously for when the client receives a batch of remote operations.
This pull request introduces these events:
before op batch
is called before anybefore op
event in a batchafter op batch
is called after anyop
event in a batchThey currently receive no parameters, but we can change that if any parameters would be appropriate here.
Best regards!