Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify type="button" to next and previous buttons in slider component #63

Closed
brcpar opened this issue Jul 22, 2020 · 1 comment · Fixed by #67
Closed

Specify type="button" to next and previous buttons in slider component #63

brcpar opened this issue Jul 22, 2020 · 1 comment · Fixed by #67

Comments

@brcpar
Copy link
Contributor

brcpar commented Jul 22, 2020

Depending on the browser, the default type can be submit which can cause ? to be added to the end of urls. Not a huge deal unless you are using hash-based routing which would essentially refresh your page.
@Toanzzz
Copy link

Toanzzz commented Oct 21, 2020

+1

When placing inside form element, clicking next and previous button will submit the form

brcpar added a commit to brcpar/vue-easy-slider that referenced this issue Oct 21, 2020
@brcpar
Update slider.vue
6b81005 
Make type="button" for the previous and next buttons. Fixes shhdgit#63
@brcpar brcpar mentioned this issue Oct 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update slider.vue brcpar/vue-easy-slider
2 participants
@brcpar @Toanzzz