GitHub Actions Support for Building arm64 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WITH_CAROTENE=ON won't work with ARM64
Co-authored-by: M. Scott Ford <[email protected]>
mscottford
force-pushed
the
arm64-support-improvements
branch
12 times, most recently
from
66f14c7
to
2e4a090
Compare
mscottford
force-pushed
the
arm64-support-improvements
branch
from
2e4a090
to
b8e4dcc
Compare
mscottford
commented
Jul 18, 2024
Comment on lines
+40
to
+42
| - name: Install NASM to support SIMD optimizations | ||
| uses: ilammy/setup-nasm@v1 | ||
|
|
There was a problem hiding this comment.
I'd like to call attention to this change, because I made it in response to a warning message that I saw while debugging. It said that SIMD wasn't being enabled because NASM wasn't found, and that "performance will suffer".
There was a problem hiding this comment.
It might make sense to move that to a different PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is based on #25.