Vpc and tag improvements #9
Conversation
Initial commit that allows specifying which address you want to use, public or private, in order to connect to the instance. The default is `public_ip` Also adds the ability to specify one or more tags you want to use as your templates formatting them as `tag:value`. The default is `use`.
Added the new options to the example configuration file and added some notes for the new configuration options: - address: Select which address of the instance you want to use as the host address, or the address that Shinken will use to access it - use_tags: EC2 tags that should be used as templates. The default is 'use' and the format of the template names should be key:value. This allows us to use more than one template per host, and additional flexibility. Also added documentation for 'regions' since it wasn't present at the, though it works.
|
Hi, |
Added the new options to the example configuration file and added some notes for the new configuration options: - address: Select which address of the instance you want to use as the host address, or the address that Shinken will use to access it - use_tags: EC2 tags that should be used as templates. The default is 'use' and the format of the template names should be key:value. This allows us to use more than one template per host, and additional flexibility. Also added documentation for 'regions' since it wasn't present at the, though it works.
Added the new options to the example configuration file and added some notes for the new configuration options: - address: Select which address of the instance you want to use as the host address, or the address that Shinken will use to access it - use_tags: EC2 tags that should be used as templates. The default is 'use' and the format of the template names should be key:value. This allows us to use more than one template per host, and additional flexibility. Also added documentation for 'regions' since it wasn't present at the, though it works.
|
Sorry, updated the pull request. Forgot to make some additional changes to the documentation for consistency. |
Added a vpc_address configuration option similar to the Ansible EC2 dynamic inventory module. This change allows you to specify which address you want to connect to, depending on whether it's an EC2 instance or a VPC instance. Useful when working in mixed environments that have both types. Also updated documentation to match, and some additional error checking in case there is no `public_ips` (like in the case of VPC instances)
|
Sorry about the close and re-open. Realized I was missing some changes that we're using in production. Added a vpc_address similar to the Ansible ec2 inventory module, allowing you specify different addresses depending on whether the instance is in EC2 or VPC. |
|
👍 |
|
Is anything needed to finalize this PR (changes, critique, etc.)? |
|
This seams to be a more flexible solution, than mine. My solution has also a problem with security groups and public subnets. Could this merged in? |
|
Hi |
Updated some of the documentation and changed functionality a bit to allow the use of more than one tag for templates. This update now allows you to use multiple key-value pairs as the template names, allowing for things like multiple inheritance.
The format of the template name that is compatible with this change would be
key:valueAlso added the ability to pick which value is the ADDRESS which is useful in a VPC environment, where we would like to access instances using the private IP address.