Skip to content

Commit

Permalink
Remove step prefix in all buildstrategy steps
Browse files Browse the repository at this point in the history
  • Loading branch information
zhangtbj committed Dec 1, 2020
1 parent 48725c8 commit 34d9184
Show file tree
Hide file tree
Showing 13 changed files with 31 additions and 31 deletions.
8 changes: 4 additions & 4 deletions docs/buildstrategies.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ metadata:
name: kaniko-small
spec:
buildSteps:
- name: step-build-and-push
- name: build-and-push
image: gcr.io/kaniko-project/executor:v1.3.0
workingDir: /workspace/source
securityContext:
Expand Down Expand Up @@ -225,7 +225,7 @@ metadata:
name: kaniko-medium
spec:
buildSteps:
- name: step-build-and-push
- name: build-and-push
image: gcr.io/kaniko-project/executor:v1.3.0
workingDir: /workspace/source
securityContext:
Expand Down Expand Up @@ -373,7 +373,7 @@ If we will apply the following resources:
- We will use a modified buildah strategy, with the following steps resources:

```yaml
- name: step-buildah-bud
- name: buildah-bud
image: quay.io/buildah/stable:latest
workingDir: /workspace/source
securityContext:
Expand All @@ -395,7 +395,7 @@ If we will apply the following resources:
volumeMounts:
- name: buildah-images
mountPath: /var/lib/containers/storage
- name: step-buildah-push
- name: buildah-push
image: quay.io/buildah/stable:latest
securityContext:
privileged: true
Expand Down
10 changes: 5 additions & 5 deletions docs/proposals/buildstrategy-steps-resources.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ metadata:
name: buildpacks-v3-default
spec:
buildSteps:
- name: step-prepare
- name: prepare
image: docker.io/paketobuildpacks/builder:full
securityContext:
runAsUser: 0
Expand All @@ -178,7 +178,7 @@ spec:
request:
cpu: "10m"
memory: "128Mi"
- name: step-detect
- name: detect
image: docker.io/paketobuildpacks/builder:full
securityContext:
runAsUser: 1000
Expand All @@ -198,7 +198,7 @@ spec:
request:
cpu: "250m"
memory: "50Mi"
- name: step-restore
- name: restore
image: docker.io/paketobuildpacks/builder:full
securityContext:
runAsUser: 1000
Expand All @@ -213,7 +213,7 @@ spec:
mountPath: /cache
- name: layers-dir
mountPath: /layers
- name: step-build
- name: build
image: docker.io/paketobuildpacks/builder:full
securityContext:
runAsUser: 1000
Expand All @@ -234,7 +234,7 @@ spec:
request:
cpu: "500m"
memory: "1Gi"
- name: step-export
- name: export
image: docker.io/paketobuildpacks/builder:full
securityContext:
runAsUser: 1000
Expand Down
2 changes: 1 addition & 1 deletion docs/proposals/runtime-image.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ metadata:
spec:
taskSpec:
steps:
- name: step-runtime-dockerfile
- name: runtime-dockerfile
image: $(build.builder.image)
securityContext:
runAsUser: 0
Expand Down
4 changes: 2 additions & 2 deletions samples/buildstrategy/buildah/buildstrategy_buildah_cr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: buildah
spec:
buildSteps:
- name: step-buildah-bud
- name: buildah-bud
image: quay.io/buildah/stable:latest
workingDir: /workspace/source
securityContext:
Expand All @@ -27,7 +27,7 @@ spec:
volumeMounts:
- name: buildah-images
mountPath: /var/lib/containers/storage
- name: step-buildah-push
- name: buildah-push
image: quay.io/buildah/stable:latest
securityContext:
privileged: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: buildpacks-v3-heroku
spec:
buildSteps:
- name: step-prepare
- name: prepare
image: heroku/buildpacks:18
securityContext:
runAsUser: 0
Expand Down Expand Up @@ -33,7 +33,7 @@ spec:
mountPath: /cache
- name: layers-dir
mountPath: /layers
- name: step-create
- name: build-and-push
image: heroku/buildpacks:18
securityContext:
runAsUser: 1000
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: buildpacks-v3-heroku
spec:
buildSteps:
- name: step-prepare
- name: prepare
image: heroku/buildpacks:18
securityContext:
runAsUser: 0
Expand Down Expand Up @@ -33,7 +33,7 @@ spec:
mountPath: /cache
- name: layers-dir
mountPath: /layers
- name: step-create
- name: build-and-push
image: heroku/buildpacks:18
securityContext:
runAsUser: 1000
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: buildpacks-v3
spec:
buildSteps:
- name: step-prepare
- name: prepare
image: docker.io/paketobuildpacks/builder:full
securityContext:
runAsUser: 0
Expand Down Expand Up @@ -33,7 +33,7 @@ spec:
mountPath: /cache
- name: layers-dir
mountPath: /layers
- name: step-create
- name: build-and-push
image: docker.io/paketobuildpacks/builder:full
securityContext:
runAsUser: 1000
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: buildpacks-v3
spec:
buildSteps:
- name: step-prepare
- name: prepare
image: docker.io/paketobuildpacks/builder:full
securityContext:
runAsUser: 0
Expand Down Expand Up @@ -33,7 +33,7 @@ spec:
mountPath: /cache
- name: layers-dir
mountPath: /layers
- name: step-create
- name: build-and-push
image: docker.io/paketobuildpacks/builder:full
securityContext:
runAsUser: 1000
Expand Down
2 changes: 1 addition & 1 deletion samples/buildstrategy/kaniko/buildstrategy_kaniko_cr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: kaniko
spec:
buildSteps:
- name: step-build-and-push
- name: build-and-push
image: gcr.io/kaniko-project/executor:v1.3.0
workingDir: /workspace/source
securityContext:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: source-to-image-redhat
spec:
buildSteps:
- name: step-s2i-generate
- name: s2i-generate
image: registry.redhat.io/ocp-tools-43-tech-preview/source-to-image-rhel8:latest
workingDir: /workspace/source
args:
Expand All @@ -17,7 +17,7 @@ spec:
volumeMounts:
- name: s2i
mountPath: /s2i
- name: step-buildah-bud
- name: buildah-bud
image: quay.io/buildah/stable:latest
workingDir: /s2i
securityContext:
Expand All @@ -32,7 +32,7 @@ spec:
mountPath: /s2i
- name: buildah-images
mountPath: /var/lib/containers/storage
- name: step-buildah-push
- name: buildah-push
image: quay.io/buildah/stable:latest
securityContext:
privileged: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
- name: DOCKER_CONFIG
value: /tekton/home/.docker
image: gcr.io/kaniko-project/executor:v1.3.0
name: step-build-and-push
name: build-and-push
securityContext:
runAsUser: 0
allowPrivilegeEscalation: false
Expand Down
4 changes: 2 additions & 2 deletions test/buildstrategy_samples.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ metadata:
name: buildah
spec:
buildSteps:
- name: step-buildah-bud
- name: buildah-bud
image: quay.io/buildah/stable:latest
workingDir: /workspace/source
securityContext:
Expand All @@ -36,7 +36,7 @@ spec:
volumeMounts:
- name: buildah-images
mountPath: /var/lib/containers/storage
- name: step-buildah-push
- name: buildah-push
image: quay.io/buildah/stable:latest
securityContext:
privileged: true
Expand Down
8 changes: 4 additions & 4 deletions test/clusterbuildstrategy_samples.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ metadata:
name: buildah
spec:
buildSteps:
- name: step-buildah-bud
- name: buildah-bud
image: quay.io/buildah/stable:latest
workingDir: /workspace/source
securityContext:
Expand All @@ -36,7 +36,7 @@ spec:
volumeMounts:
- name: buildah-images
mountPath: /var/lib/containers/storage
- name: step-buildah-push
- name: buildah-push
image: quay.io/buildah/stable:latest
securityContext:
privileged: true
Expand Down Expand Up @@ -68,7 +68,7 @@ metadata:
name: buildah
spec:
buildSteps:
- name: step-buildah-bud
- name: buildah-bud
image: quay.io/buildah/stable:latest
workingDir: /workspace/source
securityContext:
Expand All @@ -90,7 +90,7 @@ spec:
volumeMounts:
- name: buildah-images
mountPath: /var/lib/containers/storage
- name: step-buildah-push
- name: buildah-push
image: quay.io/buildah/stable:latest
securityContext:
privileged: true
Expand Down

0 comments on commit 34d9184

Please sign in to comment.