Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in build v2 repo #181

Closed
routerhan opened this issue May 7, 2020 · 5 comments
Closed

Improve error handling in build v2 repo #181

routerhan opened this issue May 7, 2020 · 5 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@routerhan
Copy link
Contributor

Idea:

Mainly for the buildrun controller, we have different places where we return 2 errors during reconciliation. Where one of those errors can be nil, which is very misleading when reading the operator logs.

Example of the above is https:/redhat-developer/build/blob/master/pkg/controller/buildrun/buildrun_controller.go#L116

Expected result:

  • Only return multiple errors if each error is not nil.
@routerhan
Copy link
Contributor Author

@qu1queee for your reference.

@Avni-Sharma
Copy link
Contributor

Also, proper logging required on errors, for eg, as mentioned here https:/redhat-developer/build/blob/56dc0293ae24813e70efc25c352b67117590b540/pkg/controller/buildrun/buildrun_controller.go#L183

@qu1queee qu1queee added the kind/feature Categorizes issue or PR as related to a new feature. label May 8, 2020
@qu1queee
Copy link
Contributor

qu1queee commented May 8, 2020

Adding this to #174 for a short discussion(shouldnt take more than 1 min)

@routerhan
Copy link
Contributor Author

routerhan commented May 19, 2020

Pls refer to this PR for more discussion : #220

@zhangtbj
Copy link
Contributor

zhangtbj commented Jun 2, 2020

PR is merged. Thanks @routerhan

@zhangtbj zhangtbj closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants