Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Build contextDir in Buildpacks #195

Closed
qu1queee opened this issue May 13, 2020 · 1 comment
Closed

Add support for Build contextDir in Buildpacks #195

qu1queee opened this issue May 13, 2020 · 1 comment
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@qu1queee
Copy link
Contributor

Idea:
Currently specifying a subpath where the source code is located does not work for Buildpacks strategies. This is done via the contextDir key. For Buildpacks, it would be interesting to have sample files for different runtimes. For example this repository host many different runtime applications, so using a single repo source for future buildpacks samples would be ideal. But without the contextDir support, this is not possible.

Acceptance_Criteria:
Add the missing functionality in buildpacks strategies, PR this and ensure all tests are happy.

@qu1queee qu1queee added the kind/feature Categorizes issue or PR as related to a new feature. label May 13, 2020
@qu1queee qu1queee self-assigned this May 13, 2020
@sbose78
Copy link
Member

sbose78 commented May 15, 2020

Got it, so the buildpacks strategy doesn't acknowledge contextDir at the moment - and that's gotta be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants