Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak Makefile #1019

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Tweak Makefile #1019

merged 1 commit into from
Mar 23, 2022

Conversation

HeavyWombat
Copy link
Contributor

Changes

Remove GO111MODULE variables as this is the default now.

Add annotation to omit command print for rm and mkdir.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@HeavyWombat
Clean-up Makefile
3546d23 
Remove `GO111MODULE` variables as this is the default now.

Add annotation to omit command print for `rm` and `mkdir`.
@HeavyWombat HeavyWombat added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 22, 2022
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Mar 22, 2022
@HeavyWombat HeavyWombat mentioned this pull request Mar 22, 2022
Merged
11 tasks
@otaviof
Copy link
Member

otaviof commented Mar 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
SaschaSchwarze0
SaschaSchwarze0 approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6a6e5c9 into main Mar 23, 2022
@qu1queee qu1queee deleted the update/Makefile branch March 23, 2022 11:35
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.9.0 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@gabemontero gabemontero Awaiting requested review from gabemontero

@imjasonh imjasonh Awaiting requested review from imjasonh

@dalbar dalbar Awaiting requested review from dalbar

Assignees

@otaviof otaviof

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note
Projects
None yet
Milestone
release-v0.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HeavyWombat @otaviof @SaschaSchwarze0 @openshift-merge-robot