Validate all referenced secrets

[SaschaSchwarze0]

While playing around, I noticed that the source secret is not validated. The code then showed me that only the output secret is validated. I added the validation for the source secret as well as the image builder secret.

[HeavyWombat]

I personally think the check logic could be rewritten a bit for readability and reduced loop iterations.

[HeavyWombat]

To be honest, it took me two passes to follow the logic. I think touching the loop index variable (i) by manually decreasing it, that was part of the confusion to me. As a suggestion: We could make it easier to read and reduce the nested loops by translating it to two simple loops and a lookup.

Also, the error message only showed one of the missing secrets, not all. The suggestion includes a fix idea for that, too.

Suggested change

	for _, secret := range list.Items {
	secretNamesLength := len(secretNames)
	for i := 0; i < secretNamesLength; i++ {
	if secret.Name == secretNames[i] {
	// remove item from array
	secretNamesLength--
	secretNames[i] = secretNames[secretNamesLength]
	secretNames[secretNamesLength] = ""
	secretNames = secretNames[:secretNamesLength]
	// decrease i
	i--
	var lookUp = map[string]bool{}
	for _, secretName := range secretNames {
	lookUp[secretName] = false
	}
	for _, secret := range list.Items {
	lookUp[secret.Name] = true
	}
	var missingSecrets = []string{}
	for name, found := range lookUp {
	if !found {
	missingSecrets = append(missingSecrets, name)
	}
	}
	if len(missingSecrets) > 0 {
	return fmt.Errorf("required secrets not found: %s", strings.Join(missingSecrets, ", "))
	}

[SaschaSchwarze0]

Yeah, I am still struggling with the lack of collection streaming in Go. I'm going to change it.

[SaschaSchwarze0]

Done. I retained the error message as this is used already in downstream documentation.

[zhangtbj]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangtbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zhangtbj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment