Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate nil pointer exceptions during BuildRun Reconcile #396

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Validate nil pointer exceptions during BuildRun Reconcile #396

merged 1 commit into from
Sep 17, 2020

Commits on Sep 16, 2020

  1. Validate nil pointer exceptions during BuildRun Reconcile 

    When generating the rampup metrics, we needed to validate for nil
pointers in order to avoid some panic() scenarios. Adding a test
case for this validation.

When metrics are not used, some variables are not initialized, leading
to panic() scenarios when using them later in the reconciliation of the
BuildRun controller. Adding some if conditionals to validate nils.
    @qu1queee
    qu1queee committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    f082e14 View commit details
    Browse the repository at this point in the history