Fix/nil pointer reference in updateBuildRunUsingTaskRunCondition #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `gofmt -s -w` to fix issue with different formatting.
There seems to be a rather rare case where we have a setup in which a TaskRun has a completion timestamp and condition reason `TaskRunReasonFailed`, while the respective pod has containers which are not terminated, (yet). In this case the code ends up with a nil pointer dereferences and crashes the running operator pod. See #591 for details. Change `updateBuildRunUsingTaskRunCondition` function to set the failed container name only if a failed container could be looked-up. Add unit-test to construct a represenation of the error scenario and test that the `Reconcile` runs through without a nil pointer dereference.
openshift-ci-robot
added
the
release-note
SaschaSchwarze0
approved these changes
Feb 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There seems to be a rather rare case where we have a setup in which a TaskRun
has a completion timestamp and condition reason
TaskRunReasonFailed, whilethe respective pod has containers which are not terminated, (yet). In this
case the code ends up with a nil pointer dereferences and crashes the running
operator pod. See #591 for details.
Fixes #591
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes