Correct and optimize reconciliation on deletion

[SaschaSchwarze0]

Changes

While testing something, I noticed that deleting a build caused a reconciliation on the build:

Feb 24 13:55:02 build-operator-dbbb6b95-272vf build-operator debug {"level":"debug","ts":1614171301.8459392,"logger":"build.build-controller","msg":"start reconciling Build","namespace":"default","name":"test-kaniko-xlarge-97"}
Feb 24 13:55:02 build-operator-dbbb6b95-272vf build-operator debug {"level":"debug","ts":1614171301.8459957,"logger":"build.build-controller","msg":"finish reconciling build. build was not found","namespace":"default","name":"test-kaniko-xlarge-97"}

That caused me to look into the reconciliations on delete. For Builds, I simply always return false in the predicate function because there is nothing we need to do when a Build is deleted since we do not have any finalizers.

The same applies for BuildRuns.

For TaskRuns, I am fixing a bug. When a TaskRun got deleted, we unconditionally changed the BuildRun to Failed state stating that the TaskRun doesn't exist. This imo makes sense as long as the TaskRun is not completed, but if the TaskRun is completed, then we also updated the BuildRun to a (final) Success or Failed state already for the Update event. I am therefore only reconciling on TaskRun deletion when the CompletionTime is nil. Also added integration tests.

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

Release Notes

Fixing the predicate functions for delete operations so that unnecessary reconciliations are omitted and a completed BuildRun does not get updated if the TaskRun gets deleted.

[SaschaSchwarze0]

/test 4.4-unit

[qu1queee]

Nice findings, code looks good, test cases can be better, asking for a change in one test spec.

[qu1queee]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qu1queee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment