Allow to configure MaxConcurrentReconciles for our controllers

[SaschaSchwarze0]

Changes

With the Git validation being added to the build reconciliation, we are observing increases in the time it takes to reconcile a build. This time is critical at the startup of the controller when all builds are reconciled. New builds that are getting created will then not be reconciled within a reasonable time. Example:

With 1000 builds in the system that do not use Git validation, we see the controller reconciling all of them in a little more than a minute. With Git validation enabled, it takes more than six minutes.

In this PR, I am exposing the MaxConcurrentReconciles controller setting as environment variable for our four controllers. The default is still 1.

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

Release Notes

Exposing MaxConcurrentReconciles configuration of controllers to allow increasing them from the default (1) to be able to handle a larger amount of objects in the system

[SaschaSchwarze0]

Hm, the sanity check failed in files I did not change. Correcting this in a separate commit.

[zhangtbj]

Hi Sascha,

Please fix the code conflict.

[gabemontero]

/approve

@zhangtbj feel free to put a slash lgtm in this PR if you happy with @SaschaSchwarze0 's responses to your comments and we can merge this one

fwiw LGTM

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhangtbj]

A quick question, is that possible to skip this default setting here? And let framework to set default values for us, like before.

We manually set default to 1 for all, but I am not sure if the framework change the default value in future, then they will be mismatch.

[SaschaSchwarze0]

Done.

[zhangtbj]

It looks better to have a check by using zero.

Thanks Sascha!

[zhangtbj]

/lgtm