Modify default branch behaviour for git repos #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
release-note
|
hmmm ... the requiring of setting kind label on PRs does not seem taking hold @adambkaplan we might need to revisit opnshift/release repo and see if something got changed on us |
|
/approve @qu1queee should we give some hint of this in https:/shipwright-io/build/blob/master/docs/build.md#defining-the-source and the text explaining |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@gabemontero totally, let me do this |
The behaviour for a git repo revision was being hardcoded to `master`, which is incorrect, while github is already creating the default branch to `main` and also because the default Tekton behaviour does not take place if the revision parameter is not specified. Tekton defaults behaviour triggers a git symbolic-link to HEAD, which we should allow to happen if the user does not specify a revision in the Build source.
qu1queee
force-pushed
the
qu1queee/default_git_branch_fix
branch
from
fe99340
to
af7d73f
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The behaviour for a git repo revision was being hardcoded to
master,which is incorrect, while github is already creating the default branch
to
mainand also because the default Tekton behaviour was not takingplace if the revision parameter is not specified.
Tekton defaults behaviour triggers a git symbolic-link to HEAD, which
we should allow to happen if the user does not specify a revision in the
Build source.
Fixes #518
Tekton introduced the default behaviour in tektoncd/pipeline@9aff0a0
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes