Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release jobs - only run on shipwright-io/build #639

Conversation

adambkaplan
Copy link
Member

Changes

Add condition to ensure nightly and regular release jobs only run on the
shipwright-io/build repository. This ensures the nightly and official release jobs
do not run on forks.

/kind bug

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Github actions: ensure nightly and release jobs are not run on contributor forks.

Add condition to ensure nightly and regular release jobs only run on the
shipwright-io/build repository. This ensures the nightly and official release jobs
do not run on forks.
@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Label for when a PR has specified a release note labels Mar 4, 2021
@adambkaplan
Copy link
Member Author

/assign @imjasonh

Copy link
Contributor

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@zhangtbj
Copy link
Contributor

zhangtbj commented Mar 5, 2021

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangtbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit 019c2f2 into shipwright-io:master Mar 5, 2021
@SaschaSchwarze0
Copy link
Member

Nice @adambkaplan. Also noticed that problem. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants