-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Buildkit #675
Add support for Buildkit #675
Conversation
Could you please update the readme? ( "Samples" section, not the "roadmap". We should probably remove the latter). |
@sbose78 yes, this PR still needs more work, mainly docs. Im gonna wait some more time for feedback, then I will update as you requested. |
e19d94c
to
8674b99
Compare
8674b99
to
1033dea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Please add an e2e test case for completeness. Adding some suggestions.
1033dea
to
a62c6e0
Compare
a62c6e0
to
22995ef
Compare
This is a daemonless flavor. It can run as rootless with some specific configurations.
eeb9b06
to
2ac15ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Stumbled over one more typo.
Document usage of BuildKit and update all related docs
2ac15ea
to
bf03fa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fixes #407
This adds support for rootless buildkit.
Some of the key things from using buildkit are:
This adds an
insecure
strategy, so that we can push to the insecure local in-cluster HTTP registry in e2e tests, otherwise it will not work with a secure one.Submitter Checklist
Release Notes