Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SpecRuntimeSecretRefNotFound -> SpecBuilderSecretRefNotFound #686

Merged

Conversation

imjasonh
Copy link
Contributor

Changes

The status seems to be misnamed, since it only applies when the builder image's secretRef isn't found, and isn't related to the runtime-image feature as far as I can tell.

This was mainly a scripted change:

git grep -l "SpecRuntimeSecretRefNotFound" | xargs sed -i '' -e 's/SpecRuntimeSecretRefNotFound/SpecBuilderSecretRefNotFound/g'

... with one manual change in a doc comment.

/kind cleanup

Submitter Checklist

  • [y] Includes tests if functionality changed/was added
  • [y] Includes docs if changes are user-facing
  • [y] Set a kind label on this PR
  • [y] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Status reason "SpecRuntimeSecretRefNotFound" changed to "SpecBuilderSecretRefNotFound" to accurately reflect its use.

/assign @qu1queee

@openshift-ci-robot openshift-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Label for when a PR has specified a release note labels Mar 21, 2021
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0430ccc into shipwright-io:master Mar 22, 2021
@qu1queee qu1queee added this to the release-v0.4.0 milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants