Multi-platform support #711
Conversation
openshift-ci-robot
added
the
release-note
SaschaSchwarze0
added
the
kind/feature
docs/buildstrategies.md
Outdated
| - [How does Tekton Pipelines handle resources](#how-does-tekton-pipelines-handle-resources) | ||
| - [Examples of Tekton resources management](#examples-of-tekton-resources-management) | ||
| - [Annotations](#annotations) | ||
| - [BuildStrategies](#buildstrategies) |
There was a problem hiding this comment.
GitHub generates its own table of contents now, we might consider not writing our own anymore (doesn't have to be in this PR, just something to consider)
SaschaSchwarze0
force-pushed
the
sascha-multi-platform-support
branch
from
7387bed
to
f24d40b
Compare
|
Rebased to resolve merge conflicts. |
SaschaSchwarze0
force-pushed
the
sascha-multi-platform-support
branch
from
f24d40b
to
2a576a0
Compare
| KO_DOCKER_REPO="$IMAGE_HOST/$IMAGE" GOFLAGS="${GO_FLAGS}" ko resolve -t "$TAG" --bare -R -f deploy/ > release.yaml | ||
| KO_DOCKER_REPO="$IMAGE_HOST/$IMAGE" GOFLAGS="${GO_FLAGS} -tags=pprof_enabled" ko resolve -t "$TAG-debug" --bare -R -f deploy/ > release-debug.yaml | ||
| KO_DOCKER_REPO="$IMAGE_HOST/$IMAGE" GOFLAGS="${GO_FLAGS}" ko resolve -t "$TAG" --bare --platform=all -R -f deploy/ > release.yaml | ||
| KO_DOCKER_REPO="$IMAGE_HOST/$IMAGE" GOFLAGS="${GO_FLAGS} -tags=pprof_enabled" ko resolve -t "$TAG-debug" --bare --platform=all -R -f deploy/ > release-debug.yaml |
There was a problem hiding this comment.
For reference - ko inspects the manifest list of the base image, and then does a golang build for each platform in the manifest [1]. I assume this also means ko resolve will push a manifest list.
There was a problem hiding this comment.
Yep, that's how it looks: https://hub.docker.com/r/saschaschwarze/shipwright-build-controller/tags?page=1&ordering=last_updated
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Changes
This enables our build to produce multi-platform images. Details:
ko0.8.1, 0.8.0 probably also works, but I locally worked with the latest version.GOOSandGOARCHtoGO_OSandGO_ARCH. I need to do this to prevent those variable to be present anywhere, especially in thereleasetarget wherekois now ran with the--platform=allargument to produce the multi-platform image. In that case, theGOOSandGOARCHenvironment variables must not be set. For other targets that are invokingko, I am setting those two environment variables specifically to make sure the image is built for the platform of the user's machine. Otherwise,kowould always be buildinglinux/amd64kobuild strategy to be cross-platform, building actually for the platform of the Kube cluster until we can give more control to the Build user once we havespec.params.Fixes #698
Submitter Checklist
Release Notes