Map ImagePullPolicy from build strategy step to TaskRun step #791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When defining a build strategy, the author defines which images are to be used. For certain tools, beside immutable image tags for specific versions, there are also nightly or latest-like tags available that are not using
latest
themselves. In such a a case, Kubernetes sets the image pull policy implicitly toIfNotPresent
and does never reload these images so that they get outdated. Examples in our context are:In case of
latest
, Kubernetes would always contact the registry to check if there is a newer version. To enforce the very same behavior for other tags, the build strategy author needs to specify theAlways
image pull policy explicitly. But, our code does not pass this flag on to the TaskRun.Given that this has positive security impact (assuming a newer image is more secure), but some performance cost that the build strategy author explicitly "opts in", I suggest that we pass on this field.
Submitter Checklist
Release Notes