Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] shopinvader_promotion_rule from 13.0 #1064

Merged
merged 7 commits into from
Jun 14, 2023
Merged

[14.0][MIG] shopinvader_promotion_rule from 13.0 #1064

merged 7 commits into from
Jun 14, 2023

Conversation

acsonefho
Copy link
Contributor

@acsonefho acsonefho commented Aug 10, 2021 •
edited by rousseldenis
Loading

Migration of shopinvader_promotion_rule from #894 (13.0)

Depends on

Remove:

  • Entry in test-requirements

@sebastienbeau sebastienbeau added this to the 14.0 milestone Aug 11, 2021
@rousseldenis
Copy link
Contributor

@acsonefho Could you just add a technical commit with entry in test-requirements.txt in order to get tests greenify ?

@rousseldenis rousseldenis force-pushed the 14.0-mig-shopinvader_promotion_rule branch from f1c3766 to e0a8341 Compare November 17, 2021 09:41
@acsonefho
Copy link
Contributor Author

@shopinvader/shopinvader-maintainers Can you review and merge please?

@sebastienbeau
Copy link
Contributor

@acsonefho @acsonefho I am ok to merge this but we should just fix the typo (in french) in the dependency module : OCA/sale-workflow#1583 (comment)

@sebastienbeau
Copy link
Contributor

@acsonefho Can tout remove the change test-requirement as dependency have been merged?
Thanks

@rousseldenis @acsonefho
[14.0][IMP] shopinvader_promotion_rule: Remove conditional promotion …
ac7c55a 
…apply

As it was done on previous versions for performance problems,
remove it as we don't have them anymore
@acsonefho acsonefho force-pushed the 14.0-mig-shopinvader_promotion_rule branch from 1533295 to ac7c55a Compare June 14, 2023 11:15
@acsonefho
Copy link
Contributor Author

@acsonefho Can tout remove the change test-requirement as dependency have been merged? Thanks

Done

@sebastienbeau
Copy link
Contributor

/ocabot merge patch

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1064-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Jun 14, 2023
Merge PR #1064 into 14.0
0e47069 
Signed-off-by sebastienbeau
@shopinvader-git-bot
Copy link

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1064-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Jun 14, 2023
Merge PR #1064 into 14.0
36970df 
Signed-off-by sebastienbeau
@shopinvader-git-bot
Copy link

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1064-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Jun 14, 2023
Merge PR #1064 into 14.0
5c02053 
Signed-off-by sebastienbeau
@shopinvader-git-bot
Copy link

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1064-by-sebastienbeau-bump-patch, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit e17270a into shopinvader:14.0 Jun 14, 2023
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at aade5b6. Thanks a lot for contributing to shopinvader. ❤️

@acsonefho acsonefho deleted the 14.0-mig-shopinvader_promotion_rule branch June 15, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
add module merged 🎉 migration needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@acsonefho @rousseldenis @sebastienbeau @shopinvader-git-bot @qgroulard