Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Github code blocks inside block quotes. #192

Closed

Conversation

phw
Copy link

@phw phw commented Aug 25, 2015

Including test. Similar to how it is done for lists. Looks good in my tests (already using that code).

I also wondered whether the call to showdown.subParser('githubCodeBlocks') should be better part of the blockGamut parser as it seems to make sense whenever a block is processed. But I am not deep enough into the showdown code to see the possible side effects.

@tivie
Copy link
Member

tivie commented Aug 25, 2015

The reason githubCodeBlock is not called inside blockGamut is because it needs to be parsed and hashed before parsing linkDefinitions.

@tivie
Copy link
Member

tivie commented Aug 25, 2015

@thanks for your contribution. I've merged it into develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants