Merge branch 'v3' into support-h2-headings-with-steps-component

shuding · Sep 17, 2024 · 310447c · 310447c
2 parents 1c6d12b + 34035ca
commit 310447c
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 30 deletions.
diff --git a/.changeset/few-snails-occur.md b/.changeset/few-snails-occur.md
@@ -0,0 +1,5 @@
+---
+'nextra-theme-docs': patch
+---
+
+Remove the aria-hidden attribute from scroll-to-top button when it is visible
diff --git a/packages/nextra-theme-docs/src/components/back-to-top.tsx b/packages/nextra-theme-docs/src/components/back-to-top.tsx
@@ -26,7 +26,8 @@ export function BackToTop({
 }): ReactElement {
  return (
  <Button
- aria-hidden="true"
+ // elements with `aria-hidden: true` must not be focusable or contain focusable elements
+ aria-hidden={hidden ? 'true' : undefined}
  onClick={scrollToTop}
  disabled={hidden}
  className={({ disabled }) =>

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml