feat: add recommended app.kubernetes.io labels to control-plane Pods #9484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What? (description)
Closes #9450. This PR adds most of the recommended labels. These are just my own suggestions though, feel free to suggest different ones or fewer. In particular, not sure about /component vs /part-of so maybe better to leave them out? I also left out
/instance
, not quite sure what to set that to or how, probably something with the node name though.Why? (reasoning)
It's useful to have a set of uniform labels across Pods when looking at metrics and logs or even
kubectl
output, for example.Acceptance
Please use the following checklist:
make conformance
)make fmt
)make lint
)make docs
)make unit-tests
)