Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recommended app.kubernetes.io labels to control-plane Pods #9484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelbeaumont
Copy link

@michaelbeaumont michaelbeaumont commented Oct 9, 2024

Pull Request

What? (description)

Closes #9450. This PR adds most of the recommended labels. These are just my own suggestions though, feel free to suggest different ones or fewer. In particular, not sure about /component vs /part-of so maybe better to leave them out? I also left out /instance, not quite sure what to set that to or how, probably something with the node name though.

Why? (reasoning)

It's useful to have a set of uniform labels across Pods when looking at metrics and logs or even kubectl output, for example.

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
    • not really applicable
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)
    • seemed to have unrelated failures

See make help for a description of the available targets.

This PR adds most of the recommended labels.

Signed-off-by: Mike Beaumont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add newer well-known app.kubernetes.io/ labels to control plane Pods
1 participant