Update ws dependency to 7.1.2 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Issue #50 Also fix the license identifier that `npm audit` complains about. Testing Done: * `npm test` * Ran [example/index.html]() and saw chart live update
|
This will require Node 8+ now as ws has dropped support for anything older. Should do a major release bump for this I guess? |
|
Yeah, anything before Node 8 is end of life already anyway so I don't think we need to support those. But yes, do a major release bump for this. |
mpetazzoni
approved these changes
Aug 20, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ws dependency to 7.1.2
Issue #50
Also fix the license identifier that
npm auditcomplains about.Testing Done:
npm test