Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support Node.js 15, 16, 17 #73

Merged
merged 5 commits into from
Oct 20, 2021
Merged

chore: support Node.js 15, 16, 17 #73

merged 5 commits into from
Oct 20, 2021

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Oct 20, 2021

Should get rid of the warning on newer Node versions...and added the new versions to the test matrix.

@seemk seemk requested review from a team as code owners October 20, 2021 11:07
Copy link
Contributor

@jtmal-signalfx jtmal-signalfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe hold on with upgrading package-lock.json to v2, but otherwise looks good

Copy link

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2 of the lock file format should be backwards compatible.

@seemk
Copy link
Contributor Author

seemk commented Oct 20, 2021

It should, although reverted it straight after the comment. I'll leave it as-is then (with v1 lockfile) 😄

@seemk seemk merged commit 0e84cd6 into main Oct 20, 2021
@seemk seemk deleted the support-newer-nodes branch October 20, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants