Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter inaccurate CORS timings in case of more precise timeOrigin #624

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

t2t2
Copy link
Contributor

@t2t2 t2t2 commented Aug 1, 2023

Description

Chrome can now have more precise performance.timeOrigin than just int timestamp, but due to multiple layers of roundings in otel-js it can lead to cors timestamps (input = 0) to be less than performance.timeOrigin

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Manual testing

@t2t2 t2t2 requested review from a team as code owners August 1, 2023 11:44
@t2t2 t2t2 temporarily deployed to integration August 1, 2023 11:44 — with GitHub Actions Inactive
@t2t2 t2t2 merged commit ec69f0a into main Aug 1, 2023
4 checks passed
@t2t2 t2t2 deleted the filter-inaccurate-cors-2 branch August 1, 2023 11:59
@t2t2 t2t2 mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants