Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI‌ generated package artifacts aren't usable like regular dist builds #951

Closed
alerque opened this issue Jul 16, 2020 · 3 comments · Fixed by #953, #965 or #969
Closed

CI‌ generated package artifacts aren't usable like regular dist builds #951

alerque opened this issue Jul 16, 2020 · 3 comments · Fixed by #953, #965 or #969
Assignees
Labels
ci Continuous integration pipelines Not My Bug 3rd party issue outside of SILE's scope tooling Build tooling, release management, and packaging processes

Comments

@alerque
Copy link
Member

alerque commented Jul 16, 2020

Not sure what's up, but the Github Actions artifact zip, which should be an archive of make distdir is not quite that.

  1. It has a ready to run configure script but it isn't marked as executable.
  2. The file aclocal-1.15 and some friends are missing, requiring an autoreconf run which shouldn't be necessary.
  3. It doesn't have a lua_modules_dist directory. This might be desirable actually, but it was unexpected because the dist package should have it.
@alerque alerque added ci Continuous integration pipelines tooling Build tooling, release management, and packaging processes labels Jul 16, 2020
@alerque alerque added this to the v0.10.6 milestone Jul 16, 2020
@alerque alerque self-assigned this Jul 16, 2020
@alerque
Copy link
Member Author

alerque commented Jul 16, 2020

This is because we've been abusing automake (knowingly in my case). It isn't supposed to let you have dynamically generated distribution file lists.

One of many:

extra_dist = $(shell find lua_modules_dist -type f -print 2>/dev/null ||:)

We get away with cheating on this rule most of the time, but opens us up to all sorts of race conditions. See Why doesn't Automake support wildcards?

@alerque
Copy link
Member Author

alerque commented Jul 16, 2020

Point 1 here is an upstream Github bug. All the others I've dealt with.

@alerque alerque reopened this Jul 16, 2020
@alerque alerque removed this from the v0.10.6 milestone Jul 16, 2020
@alerque
Copy link
Member Author

alerque commented Jul 16, 2020

If this is a problem for anybody it looks like the solution is to zip up a zip. I mostly use the artifacts to check how the PDFs of the manual and examples came out and do file listings to see what is there. I don't care about actually compiling it very much. If anybody does (before Github fixes this bug) we need to switch to posting double zipped artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration pipelines Not My Bug 3rd party issue outside of SILE's scope tooling Build tooling, release management, and packaging processes
Projects
None yet
1 participant