Allow non-ASCII email domains in Chrome

[imnasnainaec]

Resolves #2230

---

This change is 

[codecov-commenter]

Codecov Report

Patch coverage: 70.58% and project coverage change: +0.12 🎉

Comparison is base (61631c5) 61.21% compared to head (07ea74e) 61.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
+ Coverage   61.21%   61.34%   +0.12%     
==========================================
  Files         239      239              
  Lines        8403     8405       +2     
  Branches      523      524       +1     
==========================================
+ Hits         5144     5156      +12     
+ Misses       2876     2866      -10     
  Partials      383      383              

Flag	Coverage Δ
backend	73.71% <ø> (ø)
frontend	47.68% <70.58%> (+0.27%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rc/components/Login/SignUpPage/SignUpComponent.tsx	50.00% <66.66%> (+2.17%)	⬆️
src/components/UserSettings/UserSettings.tsx	75.86% <71.42%> (+38.82%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jmgrady]

Reviewed 2 of 4 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)

---

src/components/Login/SignUpPage/SignUpComponent.tsx line 23 at r2 (raw file):

// Chrome silently converts non-ASCII characters in a Textfield of type="email".
// Use punycode.toUnicode() to convert them from punycode back to Unicode.
const punycode = require("punycode/");

Why the JavaScript style import instead of

import punycode from "punycode/";

Code quote:

const punycode = require("punycode/");

---

src/components/PasswordReset/tests/ResetPage.test.tsx line 54 at r2 (raw file):

};

const customRender = async (ui: ReactElement): Promise<void> => {

I think we want to keep the option to pass additional rendering options. This will make extending these tests less of a mystery to future maintainers. See https://testing-library.com/docs/react-testing-library/setup#custom-render

[imnasnainaec]

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @jmgrady)

---

src/components/Login/SignUpPage/SignUpComponent.tsx line 23 at r2 (raw file):

Previously, jmgrady (Jim Grady) wrote…

Why the JavaScript style import instead of

import punycode from "punycode/";

It doesn't have es6 module import support: mathiasbynens/punycode.js#116

---

src/components/PasswordReset/tests/ResetPage.test.tsx line 54 at r2 (raw file):

Previously, jmgrady (Jim Grady) wrote…

I think we want to keep the option to pass additional rendering options. This will make extending these tests less of a mystery to future maintainers. See https://testing-library.com/docs/react-testing-library/setup#custom-render

Done.

[jmgrady]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

[jmgrady]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)