This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Fix editor shortcuts on macOS; give Multiline editor more space #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set io.KeySuper properly in keyDown/Up callbacks, so that cut/copy/paste and other such functionality based on shortcut keys work on macOS. KeySuper key is used by imgui to implement this functionality (in a special case for macOS) -- for other platforms KeyCtrl is used. - allow more space in buffer for Multiline editor (previously, only 128 new characters could be added or pasted into the editor each time it was active). - eliminate unnecessary extra allocation in SetClipboardTextFn -- imgui will now always send a zero-terminated string.
|
BTW, I chose 16kb extra buffer space somewhat arbitrarily (it happens to be the size used by the buffer in the imgui demo of InputTextMultiline). Also, you can see there is not really a better solution right now than just choosing some "good size", in this discussion: ocornut/imgui#1008. |
|
Thanks for this! |
|
Thank you for merging...that was quick! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cut/copy/paste and other such functionality based on shortcut keys
work on macOS. KeySuper key is used by imgui to implement this
functionality (in a special case for macOS) -- for other platforms
KeyCtrl is used.
128 new characters could be added or pasted into the editor each
time it was active).
imgui will now always send a zero-terminated string.