Fix deprecation until versions #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcoow we should have updated all deprecation notices when releasing 2.0 😳https:/simplabs/ember-simple-auth/blob/ad52181f2995c53bddbc217776a179eadd3e40a0/addon/authenticators/devise.js#L87 for instance. |
Ouch, you're right of course 🤦♂ I fixed it now. |
marcoow
changed the title
sdebarros
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deprecating the
rejectWithResponsefor theDeviseandOAuth2PasswordGrantauthenticators, we put the wronguntilversion in the deprecation - that version should be3.0.0of course, not2.0.0which is the version the deprecations were introduced with.This also updates all previous deprecations that we took over from 1.x and didn't actually remove in 2.0.0 to now say
until: '3.0.0'.