-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Comma icon #11034
Add Comma icon #11034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with the logo i used the vector found in their app repository: https:/commaai/connect/blob/master/public/icon-vector.svg
This should be listed as the source then?
@uncenter I am not sure if it could apply here. I was confused by all other companies having the official website as their source, i could probably find a better source if thats what you want. |
Please see https:/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#source-guidelines for how we determine |
@uncenter thank you for your explanation, this has now been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing a slight difference when compared to the original with the difference tool near the bottom of the comma symbol though it looks fine in general. Might want to try touching that up a bit, otherwise good to go.
Sorry i didnt realize i accidentally force pushed. i have a new updated icon in the pr for you to checkout |
I'd like to review this again but something is up with this PR/branch specifically - I've had no issues with |
Ah, it's working now. I'll review. |
Co-authored-by: uncenter <[email protected]>
Co-authored-by: uncenter <[email protected]>
@uncenter added your changes. If there is nothing else for me to change, I hope you have a great weekend. |
I think that is it! Thanks for adding this 🚀 |
Co-authored-by: Adam Rusted <[email protected]>
Co-authored-by: uncenter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks @21st-centuryman and @uncenter!
# New Icons - Anki (#10708) (@uncenter) - Astra (#11118) (@CodeShakingSheep) - Bruno (#11101) (@CodeShakingSheep) - comma (#11034) (@21st-centuryman) - DATEV (#11160) (@CodeShakingSheep) - Doctrine (#11064) (@CodeShakingSheep) - Duplicati (#11072) (@anhthang) - Picrew (#11068) (@anhthang) - pino (#10852) (@10xLaCroixDrinker) - Rime (#11181) (@anhthang) - Tower (#11170) (@anhthang) - TypeORM (#10939) (@davesagraf) - Wagmi (#11065) (@anhthang) - yabai (#10997) (@anhthang) - YunoHost (#10947) (@CodeShakingSheep) # Updated Icons - GNOME (#11155) (@LitoMore) - Render (#11130) (@adamrusted)
Issue: closes #11033
Popularity metric:
similarweb
they also maintain openpilot
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I believe their main color is green, judging from all the green used in their events and website. I grabbed the following from the header of their website: 51FF00
As with the logo i used the vector found in their app repository:
https:/commaai/connect/blob/master/public/icon-vector.svg