saveAs window prompt always showing up

[vitorizkiimanda]

i have state saveAs: false ( eventhough the default value is false ), but saveAs Window keep showing up when download about to begin

[sindresorhus]

From what I can tell, our logic is sound:

electron-dl/index.js

Lines 54 to 56 in d87af7a

	if (!options.saveAs) {
	item.setSavePath(filePath);
	}

So this sounds like an Electron bug. I would recommend upgrading to the latest Electron version.

[vitorizkiimanda]

From what I can tell, our logic is sound:

electron-dl/index.js

Lines 54 to 56 in d87af7a

	if (!options.saveAs) {
	item.setSavePath(filePath);
	}

So this sounds like an Electron bug. I would recommend upgrading to the latest Electron version.

well I'll try to update the electron to the latest. Thanks. Gonna update here about the result

[basilky]

I can confirm this issue on Electron 10.3.1(Windows, Mac and Linux). Works fine with Electron 9.3.1(tested on Linux and Windows).

[vitorizkiimanda]

I can confirm this issue on Electron 10.3.1(Windows, Mac and Linux). Works fine with Electron 9.3.1(tested on Linux and Windows).

thanks for the info.. i can confirm the bug appears when download multiple files in parallel ( appears in electron 10, 8, 7 ).
IF only download single file the bug doesn't appear. My solution right now is by queue the download so only 1 download in a time. But its kinda messy.

any robust solution for multiple download in parallel?

[jonesaustindev]

@vitorizkiimanda @sindresorhus any update on this? I am facing a similar issue with downloading multiple files and getting the Save As dialog. Using Electron 10.1.3

[jonesaustindev]

For anyone in the future having the same issue with downloading multiple files, I went the path of doing them in order instead of setting up promises to resolve every file at once. Here's what I ended up with that worked for my use case:

      async function downloadFiles(assetUrls: string[]) {
        for (const url of assetUrls) {
          await download(mainWindow, url, {
            directory: assetsDirectory,
            saveAs: false,
            showBadge: false,
          });
        }
      }

[basilky]

Maybe related to this electron bug?
electron/electron#23273

[vitorizkiimanda]

For anyone in the future having the same issue with downloading multiple files, I went the path of doing them in order instead of setting up promises to resolve every file at once. Here's what I ended up with that worked for my use case:

      async function downloadFiles(assetUrls: string[]) {
        for (const url of assetUrls) {
          await download(mainWindow, url, {
            directory: assetsDirectory,
            saveAs: false,
            showBadge: false,
          });
        }
      }

well thanks @jonesaustindev , i created same approach with different style and it solve the problem ( eventhough not really solved the bug )

note : still waiting for the real solution for the bug