Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support relative paths if options.directory starts with "." #143

Closed
wants to merge 2 commits into from
Closed

Support relative paths if options.directory starts with "." #143

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66bca98
Support relative paths if `options.directory` starts with "."
kbuffington Oct 26, 2021
9f182e6
Fixing issues with relative path logic
kbuffington Oct 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@ function registerListener(session, options, callback = () => {}) {

const window_ = majorElectronVersion() >= 12 ? BrowserWindow.fromWebContents(webContents) : getWindowFromWebContents(webContents);

const directory = options.directory || app.getPath('downloads');
let directory = options.directory || app.getPath('downloads');
if (directory.match(/^\./)) {
kbuffington marked this conversation as resolved.
Show resolved Hide resolved
// relative path, so join to AppPath
directory = path.join(app.getAppPath(), directory);
kbuffington marked this conversation as resolved.
Show resolved Hide resolved
}
let filePath;
if (options.filename) {
filePath = path.join(directory, options.filename);
Expand Down