Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix randomly failing test #464

Merged
merged 1 commit into from
May 30, 2021
Merged

Fix randomly failing test #464

merged 1 commit into from
May 30, 2021

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 30, 2021

One of the tests is randomly failing due to a race condition.

The test checks that if a process spawns a detached process, the detached process outlives its parent. However, the current detached process is short-lived, therefore it might have exited or not depending on timing. This results in this test failing randomly in CI.

CI Tests on Node 16 are failing due to #463.

@sindresorhus sindresorhus merged commit 0d939f3 into main May 30, 2021
@sindresorhus sindresorhus deleted the fix/failing-test branch May 30, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants